lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 27 Feb 2010 12:18:29 -0600 From: Ben Gardner <gardner.ben@...il.com> To: David Brownell <david-b@...bell.net> Cc: linux-kernel@...r.kernel.org, Andres Salomon <dilinger@...labora.co.uk>, Andrew Morton <akpm@...ux-foundation.org>, David Brownell <dbrownell@...rs.sourceforge.net>, Jani Nikula <ext-jani.1.nikula@...ia.com> Subject: Re: [PATCH 2/3] cs5535-gpio: Use set_direction >> Use the set_direction method instead of direction_input and direction_output >> to enable use of the bidirectional mode. > > Any reason you aren't making the standard behavior be: > > input ... input enabled > output ... both enabled > > That would make this driver behave like most other GPIO hardware, which > would help you avoid subtle problems. > > Would there be any technical downside to that approach? That sounds like a good approach. Ben -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists