linux-kernel - Re: [GIT PULL] notification: including fanotify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1002271331570.4513@localhost.localdomain>
Date:	Sat, 27 Feb 2010 13:33:21 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Eric Paris <eparis@...hat.com>
cc:	viro@...iv.linux.org.uk, hch@...radead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [GIT PULL] notification: including fanotify



On Sat, 27 Feb 2010, Linus Torvalds wrote:
>
>  (b) the compile has obviously never been tested with any modern gcc 
>      version. I get tons of warnings after the pull, like

In fact, this seems to be due to a commit that explicitly says:

				I do not add -Wpointer-sign to the fsnotify
    code as there are still issues with kstrdup and strlen which would pop
    out needless warnings.

but then the patch actually has

	--- a/fs/notify/Makefile
	+++ b/fs/notify/Makefile
	@@ -1,3 +1,5 @@
	+EXTRA_CFLAGS   += -Wpointer-sign
	+

WTF? Which part of this was tested AT ALL? Clearly there was not even a 
compile test going on.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/