linux-kernel - Re: [PATCH 32/66] arch/parisc/include/asm/parport.h: Checkpatch cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 27 Feb 2010 23:18:18 +0100
From:	Thibaut VARENE <T-Bone@...isc-linux.org>
To:	Andrea Gelmini <andrea.gelmini@...ma.net>
Cc:	linux-kernel@...r.kernel.org, Kyle McMartin <kyle@...artin.ca>,
	Helge Deller <deller@....de>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	linux-parisc@...r.kernel.org
Subject: Re: [PATCH 32/66] arch/parisc/include/asm/parport.h: Checkpatch 
	cleanup

On Sat, Feb 27, 2010 at 5:51 PM, Andrea Gelmini
<andrea.gelmini@...ma.net> wrote:
> arch/parisc/include/asm/parport.h:1: ERROR: trailing whitespace
> arch/parisc/include/asm/parport.h:11: WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Andrea Gelmini <andrea.gelmini@...ma.net>
> ---
>  arch/parisc/include/asm/parport.h |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/parisc/include/asm/parport.h b/arch/parisc/include/asm/parport.h
> index 00d9cc3..5cbf98b 100644
> --- a/arch/parisc/include/asm/parport.h
> +++ b/arch/parisc/include/asm/parport.h

> @@ -8,8 +8,7 @@
>  #define _ASM_PARPORT_H 1
>
>
> -static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma)
> -{
> +static int __devinit parport_pc_find_nonpci_ports (int autoirq, int autodma) {

This looks very much in contradiction with CodingStyle, since
parport_pc_find_nonpci_ports() is a function, and it's not a fix for
the quoted "WARNING". I'm guessing this wasn't intended the way it is.

HTH

T-Bone

-- 
Thibaut VARENE
http://www.parisc-linux.org/~varenet/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/