linux-kernel - Re: [tip:x86/apic] x86: Fix out of order gsi -- add remap_ioapic_gsi_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B89A398.2090101@kernel.org>
Date:	Sat, 27 Feb 2010 14:58:32 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	Ingo Molnar <mingo@...e.hu>, linux-tip-commits@...r.kernel.org,
	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	garyhade@...ibm.com, iranna.ankad@...ibm.com,
	suresh.b.siddha@...el.com, tglx@...utronix.de, trenn@...e.de
Subject: Re: [tip:x86/apic] x86: Fix out of order gsi -- add remap_ioapic_gsi_to_irq()

On 02/27/2010 02:18 PM, Eric W. Biederman wrote:
> Yinghai Lu <yinghai@...nel.org> writes:
> 
>> On 02/27/2010 01:30 PM, Eric W. Biederman wrote:
>> then will have all irq_desc for ioapic stay with BSP node.
> 
> This is what I am thinking....
> 
> static void __init setup_IO_APIC_irqs(void)
> {
> 	int apic_id, pin, idx, irq;
> 	int notcon = 0;
> 	struct irq_desc *desc;
> 	struct irq_cfg *cfg;
> 	int node = cpu_to_node(boot_cpu_id);
> 
> 	apic_printk(APIC_VERBOSE, KERN_DEBUG "init IO_APIC IRQs\n");
> 
> 	for(apic_id = 0; apic_id < nr_ioapics; apic_id++) {
> 		for (pin = 0; pin < nr_ioapic_registers[apic_id]; pin++) {
> 			idx = find_irq_entry(apic_id, pin, mp_INT);
> 			if (idx == -1) {
> 				if (!notcon) {
> 					notcon = 1;
> 					apic_printk(APIC_VERBOSE,
> 						KERN_DEBUG " %d-%d",
> 						mp_ioapics[apic_id].apicid, pin);
> 				} else
> 					apic_printk(APIC_VERBOSE, " %d-%d",
> 						mp_ioapics[apic_id].apicid, pin);
> 				continue;
> 			}
> 			if (notcon) {
> 				apic_printk(APIC_VERBOSE,
> 					" (apicid-pin) not connected\n");
> 				notcon = 0;
> 			}
> 			
> 			irq = pin_2_irq(idx, apic_id, pin);
> 
> +			if ((apic_id > 0) && (irq > 16))
> +				continue;
looks right.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/