linux-kernel - Re: [PATCH 09/14] dell-laptop: Use buffer with 32-bit physical address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100227081141.GF793@core.coreip.homeip.net>
Date:	Sat, 27 Feb 2010 00:11:42 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Matthew Garrett <mjg@...hat.com>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Stuart Hayes <stuart_hayes@...l.com>
Subject: Re: [PATCH 09/14] dell-laptop: Use buffer with 32-bit physical
 address

On Fri, Feb 26, 2010 at 10:18:42AM -0500, Matthew Garrett wrote:
> From: Stuart Hayes <stuart_hayes@...l.com>
> 
> Calls to communicate with system firmware via a SMI (using dcdbas)
> need to use a buffer that has a physical address of 4GB or less.
> Currently the dell-laptop driver does not guarantee this, and when the
> buffer address is higher than 4GB, the address is truncated to 32 bits
> and the SMI handler writes to the wrong memory address.
> 
> Signed-off-by: Stuart Hayes <stuart_hayes@...l.com>
> Acked-by: Matthew Garrett <mjg@...hat.com>
> ---
>  drivers/platform/x86/dell-laptop.c |  122 ++++++++++++++++++++++++-----------
>  1 files changed, 83 insertions(+), 39 deletions(-)
> 
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index d8b1b39..1a0bfd4 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -22,6 +22,7 @@
>  #include <linux/rfkill.h>
>  #include <linux/power_supply.h>
>  #include <linux/acpi.h>
> +#include <linux/mm.h>
>  #include <linux/i8042.h>
>  #include "../../firmware/dcdbas.h"
>  
> @@ -123,6 +124,21 @@ static struct dmi_system_id __devinitdata dell_blacklist[] = {
>  	{}
>  };
>  
> +static struct calling_interface_buffer *buffer;
> +struct page *bufferpage;

static ?

> +DEFINE_MUTEX(buffer_mutex);

static?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/