linux-kernel - Re: [PATCH v1] compiler: prevent dead store elimination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19339.35216.412591.13392@pilspetsen.it.uu.se>
Date:	Mon, 1 Mar 2010 10:32:00 +0100
From:	Mikael Pettersson <mikpe@...uu.se>
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	Roel Kluin <roel.kluin@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Mikael Pettersson <mikpe@...uu.se>, penberg@...helsinki.fi,
	Brian Gerst <brgerst@...il.com>, andi@...stfloor.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-crypto@...r.kernel.org, Herbert@...dor.apana.org.au
Subject: Re: [PATCH v1] compiler: prevent dead store elimination

Arjan van de Ven writes:
 > On Sat, 27 Feb 2010 21:47:42 +0100
 > Roel Kluin <roel.kluin@...il.com> wrote:
 > > +void secure_bzero(void *p, size_t n)
 > > +{
 > > +	memset(p, 0, n);
 > > +	ARRAY_PREVENT_DSE(p, n);
 > > +}
 > > +EXPORT_SYMBOL(secure_bzero);
 > 
 > 
 > please don't introduce bzero again to the kernel;
 > 
 > make it secure_memset() please.

In principle I would agree, but bzero() avoids the unfortunately
rather common mistake of swapping the int/size_t parameters to
memset(). I.e., people writing memset(p, n, 0) not memset(p, 0, n).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/