linux-kernel - [PATCH] cfq: remove 8 bytes of padding from cfq_rb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1267436765.2127.10.camel@localhost>
Date:	Mon, 01 Mar 2010 09:46:05 +0000
From:	Richard Kennedy <richard@....demon.co.uk>
To:	Jens Axboe <jens.axboe@...cle.com>
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: [PATCH] cfq: remove 8 bytes of padding from cfq_rb_root on 64 bit
 builds

Reorder cfq_rb_root to remove 8 bytes of padding on 64 bit builds.
    

Consequently removing 56 bytes from cfq_group and 64 bytes from
cfq_data.
    
    
Signed-off-by: Richard Kennedy <richard@....demon.co.uk>

---
patch against 2.6.33
compiled & tested on x86_64 AMD-X2

regards
Richard

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index e3dedfd..daff53d 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -77,11 +77,12 @@ struct cfq_rb_root {
 	struct rb_root rb;
 	struct rb_node *left;
 	unsigned count;
+	unsigned total_weight;
 	u64 min_vdisktime;
 	struct rb_node *active;
-	unsigned total_weight;
 };
-#define CFQ_RB_ROOT	(struct cfq_rb_root) { RB_ROOT, NULL, 0, 0, }
+#define CFQ_RB_ROOT	(struct cfq_rb_root) { .rb = RB_ROOT, .left = NULL, \
+			.count = 0, .min_vdisktime = 0, }
 
 /*
  * Per process-grouping structure


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/