linux-kernel - Re: [PATCH] udf: use ext2_find_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100301105450.GC3271@quack.suse.cz>
Date:	Mon, 1 Mar 2010 11:54:51 +0100
From:	Jan Kara <jack@...e.cz>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	Akinobu Mita <akinobu.mita@...il.com>, Jan Kara <jack@...e.cz>,
	linux-kernel@...r.kernel.org,
	Linux-Next <linux-next@...r.kernel.org>,
	linux-m68k <linux-m68k@...ts.linux-m68k.org>
Subject: Re: [PATCH] udf: use ext2_find_next_bit

On Sun 28-02-10 15:07:17, Geert Uytterhoeven wrote:
> On Sun, Feb 28, 2010 at 11:04, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> > On Thu, Feb 25, 2010 at 15:29, Akinobu Mita <akinobu.mita@...il.com> wrote:
> >> 2010/2/25 Geert Uytterhoeven <geert@...ux-m68k.org>:
> >>> On Thu, Feb 25, 2010 at 02:38, Akinobu Mita <akinobu.mita@...il.com> wrote:
> >>>> 2010/2/25 Jan Kara <jack@...e.cz>:
> >>>>> On Tue 23-02-10 23:11:13, Akinobu Mita wrote:
> >>>>>> Use ext2_find_next_bit (generic_find_next_le_bit) to find the set bit
> >>>>>> in little endian bitmap region.
> >>>
> >>> Is any of this in linux-next now?
> >>>
> >>> http://kisskb.ellerman.id.au/kisskb/buildresult/2208481/
> >>> | fs/udf/balloc.c:274: error: implicit declaration of function
> >>> 'generic_find_next_le_bit'
> >>
> >> Yep, Jan's patch caused the build breakage.
> >>
> >> Because generic_find_next_le_bit() is not available for all
> >> archtectures. So we should use ext2_find_next_bit() here.
> >
> > Most architectures use the definitions in asm-generic, so they're OK.
> > M68k doesn't. S390 is also affected, and I think arm as well (but there's no
> > arm all-modconfig build in linux-next, so I'm not 100% sure).
> >
> > I'm cooking a patch...
> 
> From c9b5c7e6ef2092be822778a0b6b3d3032c058f5b Mon Sep 17 00:00:00 2001
> From: Geert Uytterhoeven <geert@...ux-m68k.org>
> Date: Sun, 28 Feb 2010 13:06:27 +0100
> Subject: [PATCH] m68k: Implement generic_find_next_{zero_,}le_bit()
> 
> linux-next:
> fs/udf/balloc.c: In function 'udf_bitmap_new_block':
> fs/udf/balloc.c:274: error: implicit declaration of function
> 'generic_find_next_le_bit'
> 
> Convert ext2_find_next_{zero_,}bit() into generic_find_next_{zero_,}le_bit(),
> and wrap the ext2_find_next_{zero_,}bit() around the latter.
  I've now used Akinobu's patch so yours isn't really needed but it's a
good cleanup anyway in my opinion.

									Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/