linux-kernel - Re: use of setjmp/longjmp in x86 emulator.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100301132609.GJ16909@redhat.com>
Date:	Mon, 1 Mar 2010 15:26:09 +0200
From:	Gleb Natapov <gleb@...hat.com>
To:	Takuya Yoshikawa <yoshikawa.takuya@....ntt.co.jp>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, avi@...hat.com,
	mtosatti@...hat.com, zamsden@...hat.com
Subject: Re: use of setjmp/longjmp in x86 emulator.

On Mon, Mar 01, 2010 at 10:17:21PM +0900, Takuya Yoshikawa wrote:
> Gleb Natapov wrote:
> >On Mon, Mar 01, 2010 at 09:45:46PM +0900, Takuya Yoshikawa wrote:
> >>Gleb Natapov wrote:
> >>>I am looking at improving KVM x86 emulator. Current code does not
> >>Does your plan also include making the emulator independent of KVM?
> >Yes, I am planning to make it more independent from KVM that it is now
> >(by adding more callbacks to x86_emulate_ops).
> >
> >>Could you tell me about the future plan if possible?
> >>
> >We saw a lot of problems and shortcomings in the emulator recently, so
> >the plan is to improve its correctness. There is also a requirement to be
> >able single step emulated code. Having setjmp/longjmp will greatly simplify
> >the code. What are you interested in?
> 
> I am mainly interested in clearly understanding the KVM x86 emulator.
> 
> In that sense, what I felt first was it's impossible to understand why
> it is working without the deep(whole) knowledge of the KVM's architecture.
> If emulator itself is self contained, it will be much help for me.
You will need some knowledge of KVM in any case since KVM design shapes
emulator design. Think about what happens if in the middle of
instruction emulation some data from device emulated in userspace is
needed. Emulator should be able to tell KVM that exit to userspace is
needed and restart instruction emulation when data is available.

> 
> Though I do not think every instruction should be implemented, it would be
> nice if each instruction emulated is independent of KVM: if we can check the
> validity of them using only SDM, it would be really nice!
> 
Agree. That is my goal too.

> Thanks,
>   Takuya
> 
> >
> >>>handle some special cases correctly (code execution from ROM, ins/outs
> >>>to/from MMIO) and many exception conditions during instruction emulation
> >>>are not handled correctly. There is a lot of code in emulator that is
> >>>there only for exception propagation. Using setjmp/longjmp will be very
> >>>beneficial here as exception condition during instruction execution
> >>>maps very naturally to setjmp/longjmp, so my question is what about
> >>>adding setjmp/longjmp implementation to the kernel, or alternatively,
> >>>if there is a fear that it can be abused, add it locally to emulator.c?
> >>>Note that instruction emulation is always done in process context.
> >>>
> >>>--
> >>>			Gleb.
> >>>--
> >>>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >>>the body of a message to majordomo@...r.kernel.org
> >>>More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >>>Please read the FAQ at  http://www.tux.org/lkml/
> >
> >--
> >			Gleb.

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/