linux-kernel - Re: [PATCH] i2c-pnx: fix setting start/stop condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <acd2a5931003010613v4b0f7666ua47e19d72921c151@mail.gmail.com>
Date:	Mon, 1 Mar 2010 15:13:12 +0100
From:	Vitaly Wool <vitalywool@...il.com>
To:	Luotao Fu <l.fu@...gutronix.de>
Cc:	Jean Delvare <khali@...ux-fr.org>, Ben Dooks <ben-linux@...ff.org>,
	Kevin Wells <kevin.wells@....com>,
	Julia Lawall <julia@...u.dk>,
	Russell King <rmk+kernel@....linux.org.uk>,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c-pnx: fix setting start/stop condition

On Mon, Mar 1, 2010 at 1:24 PM, Luotao Fu <l.fu@...gutronix.de> wrote:
> The start/stop condtions are set in different places repetedly in the i2c-pnx
> driver.  Beside in i2c_pnx_start and i2c_pnx_stop the start/stop bit are also
> set during the transfer of a i2c message in the master_xmit/rcv calls. This is
> wrong since we can't set the start/stop condition during the transaction of a
> single message any way. As a matter of fact, the driver will sometimes set both
> the start and the stop bits at one time. This can be easily reproduced by
> sending a simple read request like e.g
> struct i2c_msg msgs[] = {
> { addr, 0, 1, buf },
> { addr, I2C_M_RD, offset, buf }
> };
> While processing the first message the i2c_pnx_master_xmit will set both the
> start_bit and the stop_bit, which will eventually confuse the slave.
>
> Fixed by remove setting start/stop condition from the transmit routines.
>
> Signed-off-by: Luotao Fu <l.fu@...gutronix.de>

Acked-by: Vitaly Wool <vitalywool@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/