linux-kernel - Re: [PATCH RFC] kconfig: place git SHA1 in .config output if in git tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1003010812410.3616@localhost.localdomain>
Date:	Mon, 1 Mar 2010 08:22:15 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
cc:	linux-kernel@...r.kernel.org, zippel@...ux-m68k.org, mingo@...e.hu,
	akpm@...ux-foundation.org
Subject: Re: [PATCH RFC] kconfig: place git SHA1 in .config output if in git
 tree

On Sun, 28 Feb 2010, Paul E. McKenney wrote:
>
> Uses "git log" to print the hash.

Please don't use "git log" for something like this.

Sure, it works, but it's kind of silly to say "I want a log, except I want 
only a single entry, and btw, I don't actually even want the log entry for 
that single entry at all, just the hash".

It boils down to "I want a log, except with none of the log part". It 
should make you go "Do I really want a log"?

If you really want the hash, maybe just using "git rev-parse HEAD" would 
do it.

However, in this case I think _any_ of those would be wrong. Wouldn't it 
make sense to use the same thing that we already compute for 'uname' 
(scripts/setlocalversion)? Especially as that one already knows how to 
handle other SCM's too (ie the whole hg/svn parts).

That script also ends up using a nicer format, ie it uses "git describe" 
to give a better idea of where it all is.

				Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/