linux-kernel - Re: [PATCH] serial: Add OMAP high-speed UART driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100301181301.08d67b03@lxorguk.ukuu.org.uk>
Date:	Mon, 1 Mar 2010 18:13:01 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	"Govindraj.R" <govindraj.raja@...com>
Cc:	"Greg KH" <greg@...ah.com>, linux-serial@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Kevin Hilman" <khilman@...prootsystems.com>,
	"Tony Lindgren" <tony@...mide.com>,
	"Olof Johansson" <olof@...om.net>
Subject: Re: [PATCH] serial: Add OMAP high-speed UART driver.

> +		 213 = /dev/ttyO0		OMAP serial port 0
> +		 214 = /dev/ttyO1		OMAP serial port 1
> +		 215 = /dev/ttyO2		OMAP serial port 2
> +		 216 = /dev/ttyO3		OMAP serial port 3

I think it might be best to allocate a dynamic tty major nowdays

Other problem is that I don't see where you hold the port lock over all
uses of port->tty. That is an assumption of the serial layer and done in
the original 8250 driver correctly.

Rest looks good and I agree that OMAP is different enough from 8250 that
it makes sense not to further clutter the 8250 driver.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/