[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4B8C047A.9030406@zytor.com>
Date: Mon, 01 Mar 2010 10:16:26 -0800
From: "H. Peter Anvin" <hpa@...or.com>
To: Thomas Gleixner <tglx@...utronix.de>
CC: Wu Fengguang <fengguang.wu@...el.com>,
Xiaotian Feng <xtfeng@...il.com>,
Sachin Sant <sachinp@...ibm.com>,
Yinghai Lu <yinghai@...nel.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
Ingo Molnar <mingo@...hat.com>,
"x86@...nel.org" <x86@...nel.org>
Subject: Re: 2.6.33-git6 boot failure[x86_64] (WARN: at arch/x86/mm/ioremap.c:111)
On 03/01/2010 08:31 AM, Thomas Gleixner wrote:
> On Mon, 1 Mar 2010, Wu Fengguang wrote:
> Ah walk_system_ram_range() is actually doing almost the same alignment
>> check as the removed x86 page_is_ram(), except that it calls func()
>> with len=0. This happens when page_is_ram(cffa3000) is called.
>>
>> walk_system_ram_range():
>> pfn = (unsigned long)(res.start >> PAGE_SHIFT);
>> len = (unsigned long)((res.end + 1 - res.start) >> PAGE_SHIFT);
>> ret = (*func)(pfn, len, arg);
>>
>> The following patch should fix the problem.
>
> Right, that should fix it. Though I wonder whether we should warn
> prominently about non page aligned e820 mapping entries.
>
Pointless. It's way too common, and in the case of the lowmem region,
probably correct.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists