linux-kernel - [tip:x86/atomic] lib: Fix atomic64_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-9efbcd590243045111670c171a951923b877b57d@git.kernel.org>
Date:	Mon, 1 Mar 2010 19:58:07 GMT
From:	tip-bot for Luca Barbieri <luca@...a-barbieri.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
	luca@...a-barbieri.com, tglx@...utronix.de
Subject: [tip:x86/atomic] lib: Fix atomic64_add_unless test

Commit-ID:  9efbcd590243045111670c171a951923b877b57d
Gitweb:     http://git.kernel.org/tip/9efbcd590243045111670c171a951923b877b57d
Author:     Luca Barbieri <luca@...a-barbieri.com>
AuthorDate: Mon, 1 Mar 2010 19:55:45 +0100
Committer:  H. Peter Anvin <hpa@...or.com>
CommitDate: Mon, 1 Mar 2010 11:38:46 -0800

lib: Fix atomic64_add_unless test

atomic64_add_unless must return 1 if it perfomed the add and 0 otherwise.
The test assumed the opposite convention.

Reported-by: H. Peter Anvin <hpa@...or.com>
Signed-off-by: Luca Barbieri <luca@...a-barbieri.com>
LKML-Reference: <1267469749-11878-2-git-send-email-luca@...a-barbieri.com>
Signed-off-by: H. Peter Anvin <hpa@...or.com>
---
 lib/atomic64_test.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/atomic64_test.c b/lib/atomic64_test.c
index 58efdab..ee8e6de 100644
--- a/lib/atomic64_test.c
+++ b/lib/atomic64_test.c
@@ -104,11 +104,11 @@ static __init int test_atomic64(void)
 	BUG_ON(v.counter != r);
 
 	INIT(v0);
-	BUG_ON(!atomic64_add_unless(&v, one, v0));
+	BUG_ON(atomic64_add_unless(&v, one, v0));
 	BUG_ON(v.counter != r);
 
 	INIT(v0);
-	BUG_ON(atomic64_add_unless(&v, one, v1));
+	BUG_ON(!atomic64_add_unless(&v, one, v1));
 	r += one;
 	BUG_ON(v.counter != r);
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/