linux-kernel - Re: [tip:x86/irq] x86: apic: Fix mismerge, add arch_probe_nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B8C3933.7080507@goop.org>
Date:	Mon, 01 Mar 2010 14:01:23 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Ian Campbell <ijc@...lion.org.uk>
CC:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Yinghai Lu <yinghai@...nel.org>, mingo@...hat.com,
	hpa@...or.com, linux-kernel@...r.kernel.org, tglx@...utronix.de,
	mingo@...e.hu, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/irq] x86: apic: Fix mismerge, add arch_probe_nr_irqs()
 again

On 03/01/2010 01:44 PM, Ian Campbell wrote:
>> - Xen has an array irq_info[NR_IRQS] one of the last static arrays
>>    sized at NR_IRQs in the entire kernel.
>>      
> Hopefully the same info as is in that array could (and indeed should) be
> instead stored in irq_desc->chip_data. Would you object to
> arch_init_copy_chip_data and arch_free_chip_data becoming function
> pointers within the struct irq_chip?
>    

Yes, I was just about to suggest something like this.  We just need a 
mechanism of storing some per-irq info, and attaching it to the existing 
desc structure is much cleaner than maintaining some parallel structure.

You're right about the chip_data lifetime functions; it seems very odd 
that most of irq_chip is nicely factored out into a set of ops, but the 
per-chip data management is per-architecture.

With that in place, we could eliminate any dependency on irq numbers.

     J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/