linux-kernel - staging/dt3155: Question about dt3155_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <BD79186B4FD85F4B8E60E381CAEE1909021BA2A9@mi8nycmail19.Mi8.com>
Date:	Mon, 1 Mar 2010 18:19:34 -0500
From:	"H Hartley Sweeten" <hartleys@...ionengravers.com>
To:	<linux-kernel@...r.kernel.org>
Cc:	"Greg KH" <greg@...ah.com>, <ss@....gov.au>
Subject: staging/dt3155: Question about dt3155_init_isr

Hello all,

In dt3155_drv.c the function dt3155_init_isr() sets up the card for
interrupt generation.  About half way thru the function is the following:

  /* 50/60 Hz should be set before this point but let's make sure it is */
  /* right anyway */

  ReadI2C(dt3155_lbase[ minor ], CONFIG, &i2c_csr2.reg);
  i2c_csr2.fld.HZ50 = FORMAT50HZ;
  WriteI2C(dt3155_lbase[ minor ], CONFIG, i2c_config.reg);

Based on the register definitions in dt3155_io.h shouldn't this actually
be:

  ReadI2C(dt3155_lbase[ minor ], CSR2, &i2c_csr2.reg);
  i2c_csr2.fld.HZ50 = FORMAT50HZ;
  WriteI2C(dt3155_lbase[ minor ], CSR2, i2c_csr2.reg);

Regards,
Hartley