linux-kernel - Re: [PATCH 2/2] ACPI, APEI, PCIE AER, use general HEST table parsing in AER firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B8CC7BD.5020206@jp.fujitsu.com>
Date:	Tue, 02 Mar 2010 17:09:33 +0900
From:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
To:	Huang Ying <ying.huang@...el.com>
CC:	Len Brown <lenb@...nel.org>, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/2] ACPI, APEI, PCIE AER, use general HEST table parsing
 in AER firmware_first setup

(2010/03/02 10:55), Huang Ying wrote:
> ... The firmware_first setup code is moved from PCI core to
> AER driver too, because it is only AER related.
(snip)
> diff --git a/drivers/pci/pcie/aer/aerdrv_core.c b/drivers/pci/pcie/aer/aerdrv_core.c
> index c843a79..cc527c1 100644
> --- a/drivers/pci/pcie/aer/aerdrv_core.c
> +++ b/drivers/pci/pcie/aer/aerdrv_core.c
> @@ -858,6 +858,8 @@ void aer_delete_rootport(struct aer_rpc *rpc)
>   */
>  int aer_init(struct pcie_device *dev)
>  {
> +	aer_set_firmware_first(dev);
> +
>  	if (dev->port->aer_firmware_first) {
>  		dev_printk(KERN_DEBUG, &dev->device,
>  			   "PCIe errors handled by platform firmware.\n");
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 2a94309..ccfaf19 100644
(snip)
> @@ -935,7 +928,6 @@ int pci_setup_device(struct pci_dev *dev)
>  	dev->multifunction = !!(hdr_type & 0x80);
>  	dev->error_state = pci_channel_io_normal;
>  	set_pcie_port_type(dev);
> -	set_pci_aer_firmware_first(dev);
>  
>  	list_for_each_entry(slot, &dev->bus->slots, list)
>  		if (PCI_SLOT(dev->devfn) == slot->number)

The aer_init() will be called for root ports, but not for end point
devices or so on.  So please remain the firmware_first setup code in
PCI core.  Otherwise endpoint drivers will get success on call of
pci_enable_pcie_error_reporting() regardless of the firmware first.


Thanks,
H.Seto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/