linux-kernel - Re: PROBLEM: Wrong bitrate when capturing sound from Creative webcam

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h3a0jui92.wl%tiwai@suse.de>
Date:	Tue, 02 Mar 2010 11:31:53 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Arseniy Lartsev <ars3n@...dex.ru>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: PROBLEM: Wrong bitrate when capturing sound from Creative webcam

At Wed, 24 Feb 2010 20:18:38 +0300,
Arseniy Lartsev wrote:
> 
> Hello,
> 
> I've got an USB webcam (Creative VF0470 Live Cam Notebook). The problem
> is that sound from it's microphone is captured with wrong bitrate.
> Apparently it reports 16000 Hz while it should actually be 8000 (so
> the sound is 2x faster).
> 
> The following patch works for me:
> --- linux-2.6.33-rc8/sound/usb/usbaudio.c
> +++ linux-2.6.33-rc8-new/sound/usb/usbaudio.c
> @@ -2513,6 +2513,8 @@ static int parse_audio_format_rates(stru
>  			     chip->usb_id == USB_ID(0x0d8c, 0x0102)) &&
>  			    fp->altsetting == 5 && fp->maxpacksize == 392)
>  				rate = 96000;
> +			if ((rate == 16000) && (chip->usb_id = USB_ID(0x041e, 0x4068)))
> +				rate = 8000;
>  			fp->rate_table[fp->nr_rates] = rate;
>  			if (!fp->rate_min || rate < fp->rate_min)
>  				fp->rate_min = rate;
> 
> I'm not sure if this is correct, maybe there should be more conditions
> to identify this particular camera.

The change looks good to me.  Could you give your sign-off for merge,
preferably repost in a right patch style?


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/