linux-kernel - Re: [PATCH] crypto, Speed testing support for ghash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100302113408.GA1824@gondor.apana.org.au>
Date:	Tue, 2 Mar 2010 19:34:08 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Huang Ying <ying.huang@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] crypto, Speed testing support for ghash

On Mon, Mar 01, 2010 at 04:06:44PM +0800, Huang Ying wrote:
> Because ghash needs setkey, the setkey and keysize template support
> for test_hash_speed is added.
> 
> Signed-off-by: Huang Ying <ying.huang@...el.com>
> ---
>  crypto/tcrypt.c |  122 +++++++++++++++++++++++++++++++++++---------------------
>  crypto/tcrypt.h |    1 
>  2 files changed, 78 insertions(+), 45 deletions(-)
> 
> --- a/crypto/tcrypt.c
> +++ b/crypto/tcrypt.c
> @@ -395,12 +395,13 @@ out:
>  }
>  
>  static void test_hash_speed(const char *algo, unsigned int sec,
> -			    struct hash_speed *speed)
> +			    struct hash_speed *speed, u8 *keysize)

Can we possibly move keysize into struct hash_speed to reduce
the churn?

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/