linux-kernel - Re: [PATCH -next] pktcdvd: improve BKL and compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Mar 2010 13:06:21 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Peter Osterlund <petero2@...ia.com>,
	Jens Axboe <jens.axboe@...cle.com>,
	Akinobu Mita <akinobu.mita@...il.com>
Subject: Re: [PATCH -next] pktcdvd: improve BKL and compat_ioctl.c usage


* Randy Dunlap <randy.dunlap@...cle.com> wrote:

> On 02/25/10 13:27, Arnd Bergmann wrote:
> > The pktcdvd driver uses proper locking and does not need the
> > BKL in the ioctl and llseek functions of the character device,
> > so kill both. Moving the compat_ioctl handling from common code
> > into the driver itself fixes build problems when CONFIG_BLOCK is
> > disabled.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > 
> > ---
> > On Thursday 25 February 2010, Randy Dunlap wrote:
> >> From: Randy Dunlap <randy.dunlap@...cle.com>
> >>
> >> fs/compat_ioctl.c should omit pktcdvd.h and its ioctl when CONFIG_BLOCK
> >> is not enabled.  This fixes these build errors:
> >>
> >> In file included from fs/compat_ioctl.c:105:
> >> include/linux/pktcdvd.h:166: error: field 'read_queue' has incomplete type
> >> include/linux/pktcdvd.h:167: error: field 'write_queue' has incomplete type
> >> include/linux/pktcdvd.h:207: error: field 'orig_bios' has incomplete type
> >> make[2]: *** [fs/compat_ioctl.o] Error 1
> > 
> > How about this one instead, cleaning pktcdvd ioctl handling up for good?
> 
> OK, that works too.
> 
> Acked-by: Randy Dunlap <randy.dunlap@...cle.com>

FYI, this build bug now triggers upstream too - none of the fixes was applied.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/