linux-kernel - RE: [PATCH] i2c-pnx: fix setting start/stop condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <083DF309106F364B939360100EC290F805CCF929E1@eu1rdcrdc1wx030.exi.nxp.com>
Date:	Tue, 2 Mar 2010 02:12:05 +0100
From:	Kevin Wells <kevin.wells@....com>
To:	Luotao Fu <l.fu@...gutronix.de>
CC:	Vitaly Wool <vitalywool@...il.com>,
	Jean Delvare <khali@...ux-fr.org>,
	Ben Dooks <ben-linux@...ff.org>, Julia Lawall <julia@...u.dk>,
	Russell King <rmk+kernel@....linux.org.uk>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] i2c-pnx: fix setting start/stop condition


Hi Luotao,

> 
> I had a closer look into this and think that you are right. I was
> irritated by the unregular usage of start_bit and thought the stop bit is
> asserted with the i2c_pnx_stop call, which is apparently only used for
> zero sized transfers.
> 
> Fixed patch is attached with this mail.
> 

This latest patch seems to work fine and tests well with all our
I2C devices - including the pcf8563, which didn't work right before
this patch. I think it's good to go.

thanks!
Kevin

> cheers
> Luotao Fu
> --
> Pengutronix e.K.                           | Dipl.-Ing. Luotao Fu        |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/