linux-kernel - Re: [PATCH -next] i2c: fix xiic build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10f740e81003021236i662aa20fs7e092295f07aecd4@mail.gmail.com>
Date:	Tue, 2 Mar 2010 21:36:40 +0100
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	ben-linux@...ff.org, Jean Delvare <khali@...ux-fr.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] i2c: fix xiic build error

On Mon, Feb 22, 2010 at 20:03, Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
> On Mon, Feb 22, 2010 at 17:36, Randy Dunlap <randy.dunlap@...cle.com> wrote:
>> On 02/16/10 08:36, Randy Dunlap wrote:
>>> On 02/16/10 08:33, Jean Delvare wrote:
>>>> On Tue, 16 Feb 2010 08:07:05 -0800, Randy Dunlap wrote:
>>>>> On 02/04/10 12:11, Randy Dunlap wrote:
>>>>>
>>>>> This patch is still needed in linux-next-20100216.
>>>>
>>>> Nothing I can do about it, as the i2c-xiic driver is neither upstream
>>>> nor in my tree.
>>>
>>> Thanks, Jean.
>>>
>>> Next/merge.log tells me:
>>> Merge remote branch 'bjdooks-i2c/next-i2c'
>>>
>>> Ben??
>>>
>>
>> ping Ben.
>
> Yes, please. Thx!

Ping? This build problem is almost one month old now...

>> Here's the patch again.
>>
>> ---
>> From: Randy Dunlap <randy.dunlap@...cle.com>
>>
>> Add header file to fix build error:
>>
>> drivers/i2c/busses/i2c-xiic.c:493: error: implicit declaration of function 'mdelay'
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
>> Cc: "Ben Dooks (embedded platforms)" <ben-linux@...ff.org>
>> Cc: linux-i2c@...r.kernel.org
>> ---
>>  drivers/i2c/busses/i2c-xiic.c |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- linux-next-20100204.orig/drivers/i2c/busses/i2c-xiic.c
>> +++ linux-next-20100204/drivers/i2c/busses/i2c-xiic.c
>> @@ -31,6 +31,7 @@
>>  #include <linux/module.h>
>>  #include <linux/init.h>
>>  #include <linux/errno.h>
>> +#include <linux/delay.h>
>>  #include <linux/platform_device.h>
>>  #include <linux/i2c.h>
>>  #include <linux/interrupt.h>

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/