linux-kernel - Re: [patch] slab: add memory hotplug support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Mar 2010 13:17:03 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Andi Kleen <andi@...stfloor.org>
cc:	Pekka Enberg <penberg@...helsinki.fi>,
	Nick Piggin <npiggin@...e.de>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	haicheng.li@...el.com,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [patch] slab: add memory hotplug support

On Tue, 2 Mar 2010, Andi Kleen wrote:

> The patch looks far more complicated than my simple fix.
> 
> Is more complicated now better?
> 

If you still believe these are "fixes," then perhaps you don't fully 
understand the issue: slab completely lacked memory hotplug support when a 
node is either being onlined or offlined that do not have hotadded or 
hotremoved cpus.  It's as simple as that.

To be fair, my patch may appear more complex because it implements full 
memory hotplug support so that the nodelists are properly drained and 
freed when the same memory regions you onlined for memory hot-add are now 
offlined.  Notice, also, how it touches no other slab code as implementing 
new support for something shouldn't.  There is no need for additional 
hacks to be added in other slab code if you properly allocate and 
initialize the nodelists for the memory being added before it is available 
for use by the kernel.

If you'd test my patch out on your setup, that would be very helpful.  I 
can address any additional issues that you may undercover if you post the 
oops while doing either memory online or offline.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/