linux-kernel - Re: [git pull] drm request 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1003022305070.4099@skynet.skynet.ie>
Date:	Tue, 2 Mar 2010 23:16:59 +0000 (GMT)
From:	Dave Airlie <airlied@...ux.ie>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
cc:	dri-devel@...ts.sf.net, linux-kernel@...r.kernel.org
Subject: Re: [git pull] drm request 2

> 
> Never mind. I've unpulled the whole effin' mess since it doesn't even 
> compile:
> 
> 	drivers/gpu/drm/nouveau/nouveau_acpi.c:191: error: redefinition of ‘nouveau_register_dsm_handler’
> 	drivers/gpu/drm/nouveau/nouveau_drv.h:859: note: previous definition of ‘nouveau_register_dsm_handler’ was here
> 	drivers/gpu/drm/nouveau/nouveau_acpi.c:202: error: redefinition of ‘nouveau_unregister_dsm_handler’
> 	drivers/gpu/drm/nouveau/nouveau_drv.h:860: note: previous definition of ‘nouveau_unregister_dsm_handler’ was here
> 
> because not only was that VGA_SWITCHEROO Kconfig default the wrong way 
> around, the thing had clearly never ever been tested at all.
> 
> Why does sh*t like this even make it to me? Was this ever at all in -next? 
> I assume not, since that would have picked up on basic compile failures.
> 
> Grr. Things like this is what makes me go "Ok, there's always the next 
> merge window, maybe it will have gotten some testing by then".

Linux next didn't pick up this build failure, wierdly neither did the 
powerpc build I did with this turned off, because ACPI was also off on 
ppc, it was in linux-next for at least 2 days, and from what I can see 
that found the ppc problems, it never found the x86 option since it was on 
by default.

I'm going to just rip the nouveau bits out of the patch, btw nouveau is in 
staging, so you are being a bit OTT, calm down.

Dave.