linux-kernel - [PATCH 33/62] i2c: move i2c_omap's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1267572541-410-33-git-send-email-gregkh@suse.de>
Date:	Tue,  2 Mar 2010 15:28:32 -0800
From:	Greg Kroah-Hartman <gregkh@...e.de>
To:	linux-kernel@...r.kernel.org
Cc:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>,
	Kalle Jokiniemi <ext-kalle.jokiniemi@...ia.com>,
	Tony Lindgren <tony@...mide.com>,
	Paul Walmsley <paul@...an.com>,
	Richard Woodruff <r-woodruff2@...com>,
	chandra shekhar <x0044955@...com>,
	Jason P Marini <jason.marini@...il.com>,
	Syed Mohammed Khasim <x0khasim@...com>,
	Jarkko Nikula <jarkko.nikula@...ia.com>,
	Juha Yrjola <juha.yrjola@...idboot.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: [PATCH 33/62] i2c: move i2c_omap's probe function to .devinit.text

From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>

A pointer to omap_i2c_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Kalle Jokiniemi <ext-kalle.jokiniemi@...ia.com>
Cc: Tony Lindgren <tony@...mide.com>
Cc: Paul Walmsley <paul@...an.com>
Cc: Richard Woodruff <r-woodruff2@...com>
Cc: chandra shekhar <x0044955@...com>
Cc: Jason P Marini <jason.marini@...il.com>
Cc: Syed Mohammed Khasim  <x0khasim@...com>
Cc: Jarkko Nikula <jarkko.nikula@...ia.com>
Cc: Juha Yrjola <juha.yrjola@...idboot.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
---
 drivers/i2c/busses/i2c-omap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 0037e31..bd86a85 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -849,7 +849,7 @@ static const struct i2c_algorithm omap_i2c_algo = {
 	.functionality	= omap_i2c_func,
 };
 
-static int __init
+static int __devinit
 omap_i2c_probe(struct platform_device *pdev)
 {
 	struct omap_i2c_dev	*dev;
-- 
1.7.0.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/