linux-kernel - Re: [PATCH] tty: Take a 256 byte padding into account when buffering below sub-page units

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100302233935.GA1278@suse.de>
Date:	Tue, 2 Mar 2010 15:39:35 -0800
From:	Greg KH <gregkh@...e.de>
To:	Mel Gorman <mel@....ul.ie>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: Take a 256 byte padding into account when
 buffering below sub-page units

On Tue, Mar 02, 2010 at 10:24:19PM +0000, Mel Gorman wrote:
> (applies on top of linux-next, depends on "tty: Keep the default buffering to sub-page units")
> 
> The TTY layer takes some care to ensure that only sub-page allocations
> are made with interrupts disabled. It does this by setting a goal of
> "TTY_BUFFER_PAGE" to allocate. Unfortunately, while TTY_BUFFER_PAGE takes the
> size of tty_buffer into account, it fails to account that tty_buffer_find()
> rounds the buffer size out to the next 256 byte boundary before adding on
> the size of the tty_buffer.
> 
> This patch adjusts the TTY_BUFFER_PAGE calculation to take into account the
> size of the tty_buffer and the padding. Once applied, tty_buffer_alloc()
> should not require high-order allocations.
> 
> Signed-off-by: Mel Gorman <mel@....ul.ie>
> --- 
>  include/linux/tty.h |    9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Thanks, I'll queue this up after the current round of patches make it
into Linus's tree.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/