linux-kernel - Re: [PATCH RFC] kconfig: place git SHA1 in .config output if in git tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100302052142.GA6821@linux.vnet.ibm.com>
Date:	Mon, 1 Mar 2010 21:21:42 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	James Cloos <cloos@...loos.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, zippel@...ux-m68k.org, mingo@...e.hu,
	akpm@...ux-foundation.org
Subject: Re: [PATCH RFC] kconfig: place git SHA1 in .config output if in
	git tree

On Mon, Mar 01, 2010 at 08:53:19PM -0500, James Cloos wrote:
> >>>>> "Paul" == Paul E McKenney <paulmck@...ux.vnet.ibm.com> writes:
> 
> Paul> Agreed!  The "-dirty" modifier for the case of changes not yet
> Paul> checked into git looks especially helpful.
> 
> JimC> Except that the script calls »git update-index --refresh --unmerged«
> JimC> and »git diff-index --name-only HEAD«, both of which are painfully
> JimC> slow and resource intensive.
> 
> JimC> I'd hate to have that run every time I make a kernel.
> 
> Paul> Good point...  Should we have an environment variable that controls
> Paul> this behavior?
> 
> I wouldn't mind the intial idea: just the abbreviated top of three hash.
> 
> I was, next, going to write that CONFIG_LOCALVERSION_AUTO already exists
> for that, but LOCALVERSION_AUTO calls scripts/setlocalversion these days
> and that is what I'd prefer to avoid.  [SIGH]
> 
> Shows how long it has been since I last used it.  I stopped using it
> when I was maintaining my .config in git.  Now I maintain .config in a
> separate git repo, for the express purpose of avoiding a merge (rather
> than a fast forward) when I run git pull.  Something that a local edit
> of scripts/setlocalversion will, of course, prevent.
> 
> Anyone up for a CONFIG_LOCALVERSION_AUTO_DO_NOT_BOTHER_WITH_DIRTY? ☺

It looks like it would be pretty easy to make make scripts/setlocalversion
look at an environment variable to decide whether or not to do the index
update and the check for uncommitted changes.  Default would seem to
need to be to do it the slow way.

Or would that cause other problems?

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/