linux-kernel - Re: [PATCH 08/12] syscalls: add new COMPAT_SYSCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Mar 2010 07:40:00 +0100
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Jason Baron <jbaron@...hat.com>
Cc:	fweisbec@...il.com, mingo@...e.hu, rostedt@...dmis.org,
	linux-kernel@...r.kernel.org, laijs@...fujitsu.com,
	lizf@...fujitsu.com, hpa@...or.com, tglx@...utronix.de,
	mhiramat@...hat.com, benh@...nel.crashing.org, davem@...emloft.net,
	lethal@...ux-sh.org, schwidefsky@...ibm.com,
	brueckner@...ux.vnet.ibm.com, tony.luck@...el.com
Subject: Re: [PATCH 08/12] syscalls: add new COMPAT_SYSCALL_DEFINE#N() macro

On Mon, Mar 01, 2010 at 04:05:22PM -0500, Jason Baron wrote:
> On Sun, Feb 28, 2010 at 11:09:02AM +0100, Heiko Carstens wrote:
> > For architectures which select CONFIG_HAVE_SYSCALL_WRAPPERS this adds
> > unnecessary sign extension code to each compat syscall.
> > On the other hand we could get rid partly of the arch specific sign extension
> > code but that would need some other changes before as well.
> > For example this one:
> > 
> > asmlinkage long compat_sys_gettimeofday(struct compat_timeval __user *tv,
> >                 struct timezone __user *tz)
> > 
> > should be converted to a function which takes two compat_uptr_t's and let
> > the syscall code itself do the proper pointer conversion (compat_ptr()).
> > 
> > Besides that the syscall alias names for these compat calls do look a
> > bit strange:
> > 
> > 000000000008b57c T SyScompat_sys_adjtimex
> > 000000000008b57c T compat_sys_adjtimex
> > 
> > That needs to be fixed as well.
> > Or simply add a 1:1 wrapper independent of CONFIG_HAVE_SYSCALL_WRAPPERS.
> 
> ok, the later suggestion seems simpler. Below I've re-spun patch #6 and
> #8. how do they look?

Looks good to me! :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/