linux-kernel - Re: [PATCH 1/2] blkdev: fix merge_bvec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Mar 2010 08:30:14 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Dmitry Monakhov <dmonakhov@...nvz.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] blkdev: fix merge_bvec_fn return value checks

On Wed, Mar 03 2010, Dmitry Monakhov wrote:
> Jens Axboe <jens.axboe@...cle.com> writes:
> 
> > On Sat, Feb 27 2010, Dmitry Monakhov wrote:
> >> merge_bvec_fn() returns bvec->bv_len on success. So we have to check
> >> against this value. But in case of fs_optimization merge we compare
> >> with wrong value. This patch must be included in
> >>  b428cd6da7e6559aca69aa2e3a526037d3f20403
> >> But accidentally i've forgot to add this in the initial patch.
> >> To make things straight let's replace all such checks.
> >> In fact this makes code easy to understand.
> >
> > Agree, applied.
> Ohh.. as you already know this patch break dm-layer. Sorry.
> This is because dm->merge may return more than requested. So correct
> check must test against less what requested. Correct patch attached.

Have you tested this with dm and md (ie actual users of the merge_bvec
functionality) this time?

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/