linux-kernel - Re: [alsa-devel] [patch] oxygen: change || to &&

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 03 Mar 2010 09:58:06 +0100
From:	Clemens Ladisch <clemens@...isch.de>
To:	Dan Carpenter <error27@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [alsa-devel] [patch] oxygen: change || to &&

Dan Carpenter wrote:
> In the original code the condition was always true (hopefully) because
> WM8776_HPLVOL is zero.
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>

Thanks; applied.

> diff --git a/sound/pci/oxygen/xonar_wm87x6.c b/sound/pci/oxygen/xonar_wm87x6.c
> index 7754db1..dbc4b89 100644
> --- a/sound/pci/oxygen/xonar_wm87x6.c
> +++ b/sound/pci/oxygen/xonar_wm87x6.c
> @@ -68,7 +68,7 @@ static void wm8776_write(struct oxygen *chip,
>  			 OXYGEN_SPI_CEN_LATCH_CLOCK_LO,
>  			 (reg << 9) | value);
>  	if (reg < ARRAY_SIZE(data->wm8776_regs)) {
> -		if (reg >= WM8776_HPLVOL || reg <= WM8776_DACMASTER)
> +		if (reg >= WM8776_HPLVOL && reg <= WM8776_DACMASTER)
>  			value &= ~WM8776_UPDATE;
>  		data->wm8776_regs[reg] = value;
>  	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/