linux-kernel - RE: [PATCH 1/5] DMAENGINE: COH 901 318 cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 3 Mar 2010 10:45:00 +0100
From:	"Linus Walleij" <linus.walleij@...ricsson.com>
To:	"Dan Williams" <dan.j.williams@...el.com>
Cc:	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/5] DMAENGINE: COH 901 318 cleanups

[Dan Williams]
> On Tue, Mar 2, 2010 at 2:06 PM, Dan Williams 
> <dan.j.williams@...el.com> wrote:
> > On Tue, Mar 2, 2010 at 1:12 PM, Linus Walleij
> > <linus.walleij@...ricsson.com> wrote:
> >>        if (cohc->nbr_active_done)
> >> +       /*
> >> +        * If another interrupt fired while the tasklet 
> was scheduling,
> >> +        * we don't get called twice, so we have this 
> number of active
> >> +        * counter that keep track of the number of IRQs 
> expected to
> >> +        * be handled for this channel. If there happen to 
> be more than
> >> +        * one IRQ to be ack:ed, we simply schedule this 
> tasklet again.
> >> +        */
> >>                cohc->nbr_active_done--;
> >
> > Checkpatch made a justifiable wimper about this.  It looks like you
> > wanted to delete that if() according to the previous unified patch?
> >
> 
> Looks like it gets deleted later on in patch #3.  I took a stab at
> fixing it up[1], or you can just send me a new series if that does not
> look right to you.

That's perfect, thanks Dan. I was splitting the patch up using
some iterative kdiff3 excercises, I just checkpatch.pl:ed the
end result, sorry.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/