linux-kernel - RE: [PATCH] rtc-coh901331: Fix braces in resume code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Mar 2010 13:44:41 +0100
From:	"Linus Walleij" <linus.walleij@...ricsson.com>
To:	"James Hogan" <james@...anarts.com>,
	"Alessandro Zummo" <a.zummo@...ertech.it>,
	"Paul Gortmaker" <p_gortmaker@...oo.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Russell King" <rmk+kernel@....linux.org.uk>,
	<rtc-linux@...glegroups.com>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] rtc-coh901331: Fix braces in resume code.

[James]
> The else part of the if statement is indented but does not have braces
> around it. It clearly should since it uses clk_enable and clk_disable
> which are supposed to balance.
> 
> Signed-off-by: James Hogan <james@...anarts.com>

OMG, thanks for spotting this!
Acked-by: Linus Walleij <linus.walleij@...ricsson.com>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/