linux-kernel - Re: [PATCH] USB: pl2303: switch to generic write implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 3 Mar 2010 16:08:20 +0100
From:	Oliver Neukum <oliver@...kum.org>
To:	Johan Hovold <jhovold@...il.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Greg KH <greg@...ah.com>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	Peter Feuerer <peter@...e.net>
Subject: Re: [PATCH] USB: pl2303: switch to generic write implementation

Am Mittwoch, 3. März 2010 16:01:33 schrieb Johan Hovold:
> @@ -941,10 +665,8 @@ static void pl2303_release(struct usb_serial *serial)
>  
>         for (i = 0; i < serial->num_ports; ++i) {
>                 priv = usb_get_serial_port_data(serial->port[i]);
> -               if (priv) {
> -                       pl2303_buf_free(priv->buf);
> +               if (priv)
>                         kfree(priv);
> -               }
>         }
>  }

No need to test for NULL.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/