linux-kernel - Re: [PATCH] Avoid implicit constant truncation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 2 Mar 2010 16:26:49 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	imunsie@....ibm.com, linux-kernel@...r.kernel.org,
	Matthew Wilcox <matthew@....cx>, Alex Chiang <achiang@...com>,
	Bjorn Helgaas <bjorn.helgaas@...com>,
	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	linux-pci@...r.kernel.org
Subject: Re: [PATCH] Avoid implicit constant truncation

On Tue, 02 Mar 2010 16:06:33 -0800
Randy Dunlap <rdunlap@...otime.net> wrote:

> On 03/02/10 16:01, imunsie@....ibm.com wrote:
> > From: Ian Munsie <imunsie@...ibm.com>
> > 
> > When building on 64 bit platforms, the compiler throws the following
> > warning:
> > 
> > drivers/pci/probe.c:197: warning: large integer implicitly
> > truncated to unsigned type
> > 
> > This patch adds an explicit truncation to silence the compiler
> > warning.
> 
> 
> Please see/read/use Documentation/SubmittingPatches.  E.g.:
> 
> The canonical patch subject line is:
> 
>     Subject: [PATCH 001/123] subsystem: summary phrase
> 
> I.e., the subject: should tell us that this is a PCI: patch.
> 
> (or even pci: -- i don't care which)

No need to resubmit though; I usually have to fix up the summary and
changelog a bit when applying anyway.

That said, this patch rings a bell; I think the warning is signalling a
real bug in the ppc code.  IIRC Ben was going to look at it awhile
back, but I think it's mostly harmless so it's probably low on his list.

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/