[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 3 Mar 2010 17:59:04 +0100
From: Fabio Checconi <fchecconi@...il.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
Paul Turner <pjt@...gle.com>,
Dario Faggioli <faggioli@...dalf.sssup.it>,
Michael Trimarchi <michael@...dence.eu.com>,
Dhaval Giani <dhaval@...is.sssup.it>,
Tommaso Cucinotta <t.cucinotta@...up.it>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] sched: use EDF to schedule groups
> From: Peter Zijlstra <peterz@...radead.org>
> Date: Thu, Feb 25, 2010 09:28:20PM +0100
>
> On Tue, 2010-02-23 at 19:56 +0100, Fabio Checconi wrote:
> > @@ -36,7 +29,8 @@ static inline struct task_struct *rt_task_of(struct sched_rt_entity *rt_se)
> >
> > static inline struct rq *rq_of_rt_rq(struct rt_rq *rt_rq)
> > {
> > - return container_of(rt_rq, struct rq, rt);
> > + struct rt_root_rq *rt = container_of(rt_rq, struct rt_root_rq, rt_rq);
> > + return container_of(rt, struct rq, rt);
> > }
>
> I think you can write that double container_of() as a single:
>
> return container_of(rt_rq, struct rq, rt.rt_rq);
>
I'll fix it, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists