linux-kernel - Re: [PATCH mmotm] xfs: needs LIST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 03 Mar 2010 15:35:13 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Dave Chinner <david@...morbit.com>
CC:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Alex Elder <aelder@....com>, xfs-masters@....sgi.com
Subject: Re: [PATCH mmotm] xfs: needs LIST_SORT

On 03/03/10 15:25, Dave Chinner wrote:
> On Wed, Mar 03, 2010 at 11:15:17AM -0800, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@...cle.com>
>>
>> xfs uses list_sort (library function), so it needs to select it.
>> Fixes these build errors:
>> fs/xfs/linux-2.6/xfs_buf.c:1918: undefined reference to `list_sort'
>> fs/xfs/linux-2.6/xfs_buf.c:1996: undefined reference to `list_sort'
>> fs/xfs/linux-2.6/xfs_buf.c:1950: undefined reference to `list_sort'
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
>> ---
>>  fs/xfs/Kconfig |    1 +
>>  1 file changed, 1 insertion(+)
>>
>> --- mmotm-2010-0302-1838.orig/fs/xfs/Kconfig
>> +++ mmotm-2010-0302-1838/fs/xfs/Kconfig
>> @@ -2,6 +2,7 @@ config XFS_FS
>>  	tristate "XFS filesystem support"
>>  	depends on BLOCK
>>  	select EXPORTFS
>> +	select LIST_SORT
>>  	help
>>  	  XFS is a high performance journaling filesystem which originated
>>  	  on the SGI IRIX platform.  It is completely multi-threaded, can
> 
> Looks OK, but when and why did a config option get introduced for
> this?

no idea.

> I thought that Andi was trying to cull unused symbols in
> library functions automatically, so config options weren't needed...
> 
> FWIW, did UBIFS and DRM also get this select line added to them?

I just checked and both of those already select LIST_SORT.
(in -mmotm)

-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/