linux-kernel - Re: [GIT PULL] x86/mm fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100304004425.GA8035@localhost>
Date:	Thu, 4 Mar 2010 08:44:25 +0800
From:	Wu Fengguang <fengguang.wu@...el.com>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	"H. Peter Anvin" <hpa@...ux.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Sachin Sant <sachinp@...ibm.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Ian Campbell <ian.campbell@...rix.com>,
	Alok Kataria <akataria@...are.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Pasi Kärkkäinen <pasik@....fi>
Subject: Re: [GIT PULL] x86/mm fixes

On Thu, Mar 04, 2010 at 01:10:46AM +0800, Linus Torvalds wrote:
> 
> 
> On Wed, 3 Mar 2010, Wu Fengguang wrote:
> > 
> > Anyway I just hacked /usr/share/quilt/refresh to automatically run the
> > kernel style checker:
> > 
> > # wfg: check for kernel coding style
> > if [ -x scripts/checkpatch.pl ]; then
> >         scripts/checkpatch.pl $patch_file
> > fi
> 
> It's probably sensible to check things, but do remember that some of the 
> things checkpatch warns about are better left the way they are, rather 
> than make the code uglier just to make checkpatch happy.

OK. Here is the simple patch for quilt. I guess it may be hardly
acceptable for quilt upstream, so only intends to share it here.

Thanks,
Fengguang
---

--- /usr/share/quilt/refresh.orig	2010-03-04 08:38:27.000000000 +0800
+++ /usr/share/quilt/refresh	2010-03-04 08:38:29.000000000 +0800
@@ -265,6 +265,12 @@ fi
 
 patch_file=$(patch_file_name $patch)
 
+# check for kernel coding style
+# Linus: please treat its warning as recommendation instead of requirement
+if [ -x scripts/checkpatch.pl ]; then
+	scripts/checkpatch.pl -q $patch_file
+fi
+
 trap "" SIGINT
 
 tmp_result=$(gen_tempfile) || die 1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/