linux-kernel - Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5h1vg0qrrr.wl%tiwai@suse.de>
Date:	Thu, 04 Mar 2010 11:56:40 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Wei Ni <wni@...dia.com>
Cc:	'Pavel Hofman' <pavel.hofman@...ite.cz>,
	'alsa-devel' <alsa-devel@...a-project.org>,
	'linux-kernel' <linux-kernel@...r.kernel.org>,
	'akpm' <akpm@...ux-foundation.org>
Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio

At Thu, 4 Mar 2010 18:46:59 +0800,
Wei Ni wrote:
> 
> Hi, Takashi
> I think we can submit my patch first,

But your patch breaks the build when CONFIG_SND_HDA_*=y.
So, it should be fixed in your patch.


thanks,

Takashi

> then generate another patch
> to add EXPORT_SYMBOL() in hda_eld.c, and change Makefile to remove
> hda_eld.o from snd-hda-codec-xxhdmi-objs.
> 
> Thanks
> Wei.
> nvpublic
> 
> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@...e.de] 
> Sent: Thursday, March 04, 2010 5:47 PM
> To: Wei Ni
> Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
> 
> At Thu, 4 Mar 2010 10:21:39 +0800,
> Wei Ni wrote:
> > 
> > Hi, Takashi
> > 1. Yes, it can works for all Nvidia controller.
> 
> OK.
> 
> > 2. The hda_eld.o doesn't export any symbols.
> > I tried to put hda_eld.o to snd-had-codec-*, and remove had_eldo.o
> > from snd-had-codec-intelhdmi-objs, but it will build error. It need
> > to modify hda_eld.c to export symbols, it will add many changes.
> 
> Yes, this is unavoidable.  Please add EXPORT_SYMBOL()'s
> appropriately.
> 
> We can reduce them again once after all HDMI stuff is merged into
> one.
> 
> 
> thanks,
> 
> Takashi
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/