linux-kernel - Re: [PATCH 58/62] msi-laptop: Support some MSI 3G netbook that is need load SCM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <4B90839902000023000142EB@novprvlin0050.provo.novell.com>
Date:	Thu, 04 Mar 2010 10:07:53 -0700
From:	"Joey Lee" <jlee@...ell.com>
To:	<mjg59@...f.ucam.org>
Cc:	<mzxreary@...inter.de>, <gregkh@...e.de>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 58/62] msi-laptop: Support some MSI 3G netbook that
	 is need load SCM

Hi Matthew, 

於 三，2010-03-03 於 13:45 +0000，Matthew Garrett 提到：
> On Tue, Mar 02, 2010 at 09:52:12PM -0700, Joey Lee wrote:
> 
> > I developed this driver on 2.6.31 kernel, and I found this key code is
> > in 2.6.33 kernel and later.
> > There have one and only one scancode to control 3 devices when end user
> > press fn+f11 key on MSI N034.
> > Currently, we setup this mapping in HAL key and mapping it to KEY_WLAN.
> 
> Ah! The key comes through the keyboard controller? In that case, yeah, 
> just map it to KEY_RFKILL in hal isntead of KEY_WLAN. Everything should 
> work fine then. If rfkill-input is configured, it'll kill all the 
> radios. If userland claims it instead, it can cycle through with 
> whatever policy is desired.
> 

Thank's for your review and suggestion.
Per discuss for msi-laptop patchset, I will submit a bit patch for the
following change:
	- remove threeg sysfs interface.
	- add KEY_RFKILL keymapping to msi-laptop.

Does it make sense? or I still miss something important?


Thank's
Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/