linux-kernel - Re: [PATCH] ACPI / PM: Move ACPI video resume to a PM notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201003042012.36416.rjw@sisk.pl>
Date:	Thu, 4 Mar 2010 20:12:36 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	Len Brown <lenb@...nel.org>, Matthew Garrett <mjg59@...f.ucam.org>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI / PM: Move ACPI video resume to a PM notifier

On Thursday 04 March 2010, Rafał Miłecki wrote:
> 2010/3/4 Rafael J. Wysocki <rjw@...k.pl>:
> > There is a problem with the ACPI video resume routine that it's
> > executed before the GPU that may be accessed by it.  To fix this
> > issue, move the ACPI video resume to a power management notifier,
> > so that it's executed after resuming all devices, including the GPU.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
> > ---
> 
> Tested-by: Rafał Miłecki <zajec5@...il.com>

Thanks!

> It partially fixes bugzilla bug #15096 and it first needed step to fix
> it completely.

To fix that completely we'd need to avoid calling acpi_video_resume() in the
non-KMS case, but it's not clear how to tell the ACPI driver which case we're
in.  It's not certain how to reliably distinguish the KMS and non-KMS cases at
this level in the first place.

> Can we send this to stable for .32 and .33?

That depends on Len.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/