linux-kernel - Re: [PATCH 06/12] genericirq: make irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B900809.7050406@kernel.org>
Date:	Thu, 04 Mar 2010 11:20:41 -0800
From:	Yinghai Lu <yinghai@...nel.org>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Eric Biederman <ebiederm@...ssion.com>,
	LKML <linux-kernel@...r.kernel.org>, Julia Lawall <julia@...u.dk>
Subject: Re: [PATCH 06/12] genericirq: make irq_chip related function to take
 desc

On 03/04/2010 11:08 AM, Thomas Gleixner wrote:
> On Thu, 4 Mar 2010, Yinghai Lu wrote:
>> On 03/04/2010 06:31 AM, Thomas Gleixner wrote:
>>> The code which uses the chip functions needs to be changed:
>>>
>>> -	desc->chip->fun(irq);
>>> +	desc->chip->fun(desc);
>>>
>>> That's mostly in kernel/irq/* but there are some users in arch/*
>>> lowlevel irq handling code as well.
>>
>> that is our -v2 version.
> 
> I know, but the difference is that it is done by a machine.
> 
> I have been involved in more than one large scale overhaul projects in
> the kernel and most of the time I spent on those was to figure out the
> right way to do it to limit the risks.

sure.

> 
> Automated conversion is the best thing you can do and if Julia can
> whip up that rules, I'm less worried about the wholesale switchover on
> a per function basis, than I'm scared about the fully manual approach
> you took.

ok, let wait for Julia to check it...

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/