linux-kernel - Re: [PATCH] genirq: spurious irq detection for threaded irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1003042323090.2014@localhost.localdomain>
Date:	Thu, 4 Mar 2010 23:26:20 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH] genirq: spurious irq detection for threaded irqs

On Thu, 4 Mar 2010, Uwe Kleine-König wrote:
> -void note_interrupt(unsigned int irq, struct irq_desc *desc,
> -		    irqreturn_t action_ret)
> +void note_threaded_interrupt(unsigned int irq, struct irq_desc *desc,
> +		irqreturn_t action_ret)
>  {
>  	if (unlikely(action_ret != IRQ_HANDLED)) {
>  		/*
> @@ -262,6 +262,19 @@ void note_interrupt(unsigned int irq, struct irq_desc *desc,
>  	desc->irqs_unhandled = 0;
>  }
>  
> +void note_interrupt(unsigned int irq, struct irq_desc *desc,
> +		irqreturn_t action_ret)
> +{
> +	if (action_ret == IRQ_WAKE_THREAD)
> +		/* handled in irq_thread() when the threaded handler returns */
> +		return;
> +
> +	/* don't report IRQ_WAKE_THREAD | IRQ_HANDLED as bogus return value */
> +	action_ret &= ~IRQ_WAKE_THREAD;
> +
> +	note_threaded_interrupt(irq, desc, action_ret);
> +}
> +

We don't need an extra function for that. A simple

	if (action_ret & IRQ_WAKE_THREAD)
		return;

in note_interrupt() is sufficient to cover everything.

Thanks,

	tglx