linux-kernel - Re: [PATCH -next] mfd/lpc_sch: fix related depends/selects, fix build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100305181632.GB5615@sortiz.org>
Date:	Fri, 5 Mar 2010 19:16:32 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Denis Turischev <denis@...pulab.co.il>
Subject: Re: [PATCH -next] mfd/lpc_sch: fix related depends/selects, fix
 build error

Hi Randy,

On Fri, Mar 05, 2010 at 09:43:06AM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> LPC_SCH is selected by GPI_SCH and I2C_ISCH, even when PCI is not
> enabled, but LPC_SCH depends on PCI, so make GPI_SCH and I2C_ISCH
> also depend on PCI.
> 
> Those 2 selects also need to select what LPC_SCH selects,
> since kconfig does not follow selects.
Thanks, patch applied.

Cheers,
Samuel.


> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: Denis Turischev <denis@...pulab.co.il>
> ---
>  drivers/gpio/Kconfig       |    3 ++-
>  drivers/i2c/busses/Kconfig |    2 ++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> --- linux-next-20100305.orig/drivers/gpio/Kconfig
> +++ linux-next-20100305/drivers/gpio/Kconfig
> @@ -87,7 +87,8 @@ config GPIO_VR41XX
>  
>  config GPIO_SCH
>  	tristate "Intel SCH GPIO"
> -	depends on GPIOLIB
> +	depends on GPIOLIB && PCI
> +	select MFD_CORE
>  	select LPC_SCH
>  	help
>  	  Say yes here to support GPIO interface on Intel Poulsbo SCH.
> --- linux-next-20100305.orig/drivers/i2c/busses/Kconfig
> +++ linux-next-20100305/drivers/i2c/busses/Kconfig
> @@ -105,6 +105,8 @@ config I2C_I801
>  
>  config I2C_ISCH
>  	tristate "Intel SCH SMBus 1.0"
> +	depends on PCI
> +	select MFD_CORE
>  	select LPC_SCH
>  	help
>  	  Say Y here if you want to use SMBus controller on the Intel SCH
> 
> -- 
> ~Randy

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/