linux-kernel - Re: [PATCH 1/8] p9auth: set fsuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100305200703.GA29383@us.ibm.com>
Date:	Fri, 5 Mar 2010 14:07:03 -0600
From:	"Serge E. Hallyn" <serue@...ibm.com>
To:	Ashwin Ganti <ashwin.ganti@...il.com>
Cc:	Greg KH <greg@...ah.com>, rsc@...ch.com, ericvh@...il.com,
	devel@...uxdriverproject.org, linux-kernel@...r.kernel.org,
	Ron Minnich <rminnich@...il.com>, jt.beard@...il.com
Subject: Re: [PATCH 1/8] p9auth: set fsuid

Quoting Ashwin Ganti (ashwin.ganti@...il.com):
> On Fri, Feb 26, 2010 at 10:19 AM, Serge E. Hallyn <serue@...ibm.com> wrote:
> > Ashwin, Ron, Eric, (whoever else cares to take a look) I will put
> > up a git tree hopefully this weekend or monday... hmm, hang on, already
> > exists - you can take a look at
> > http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/sergeh/linux-cr.git;a=shortlog;h=refs/heads/p9auth.feb16.3
> >
> 
> Greg/Serge: Sorry for the delay. I am okay with the patches in
> general.  Thanks for making the reaping of old capabilities change as
> well along with these.
> 
> The only comment I have is that it would be nice to have a README file
> in the p9auth directory describing these changes to the semantics.

Will do.

> Especially since we are handling groups, file system checks etc. which
> is going through the capability string, it would be easier and helpful
> to understand if there is some basic documentation on each of these
> changes.
> 
> Also, I don't know if you want to further get them looked by someone

Yeah I'm going to have to re-send and cc: some core maintainers to get
their acks (or nacks).

> more knowledgeable to comment on the implications of modifying/moving
> the set*id functions over but they look alright to me.

If they look ok after I resend them, could you please send an ack I
can tack onto the patches to help out maintainers?

> I have requested Eric too a couple of days ago to take a look at these
> patches if he finds time.

Thanks, I'll give it a few more days to see if he sends comments before
resending.

> Thanks,
> Ashwin

thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/