linux-kernel - Re: [PATCH] v3 kconfig: place git SHA1 in .config output if in SCM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 5 Mar 2010 12:10:51 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Frans Pop <elendil@...net.nl>
Cc:	linux-kernel@...r.kernel.org, zippel@...ux-m68k.org, mingo@...e.hu,
	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	geert@...ux-m68k.org, cloos@...loos.com
Subject: Re: [PATCH] v3 kconfig: place git SHA1 in .config output if in SCM

On Fri, Mar 05, 2010 at 06:18:08PM +0100, Frans Pop wrote:
> On Friday 05 March 2010, Paul E. McKenney wrote:
> > But let's work out what the error strategy should be.  The below are my
> > initial guesses, I of course must defer to those more familiar with
> > kbuild and kconfig than am I.
> 
> That's not me either :-)
> I see you've not CCed linux-kbuild@...r.k.o so far. Suggest you add them 
> with the next version.

Ah, will do on v5.

> > 1.	Oddball SCM conditions should not cause the build to fail.
> > 	"Arrrgh!!!  What dot-file do I need to remove in order for
> > 	my builds to start succeeding???"
> 
> Agreed.
> 
> > 2.	Errors should leave some hint in the .config file, rather
> > 	than simply mysteriously omitting the version/dirty information.
> 
> I don't see why this should be treated any different than 
> CONFIG_LOCALVERSION_AUTO. Either setlocalversion returns something (on 
> stdout) and you use it, or it returns nothing and you don't.
> 
> With CONFIG_LOCALVERSION_AUTO errors get ignored (tested by adding 'exit 1' 
> early in the script) and output to stderr simply gets displayed (without 
> any real identification where it comes from).
> 
> If users expect the SCM version info to be there and it isn't, they will 
> investigate.

Understood, but I am concerned about the case where one person creates
the configuration and another is looking at the .config file.

> > 4.      Should the splat in the .config file identify the file and
> >         line number?  For example: "-error: scripts/confdata.c:nnnn"
> 
> IMHO definitely not. I think you're over-designing this. It's not really 
> core functionality. My viewpoint is simple: a version string should 
> contain version info, and nothing else.

s/you're over-designing this/you are freaking paranoid/

With that change, I plead guilty to charges as read.  But again, I am
worried about the case where one person generates the .config file
and someone else is reading it.  And my paranoia has proven quite useful
over the years.  ;-)

							Thanx, Paul

> > After this is done, I am going to return to something easier to
> > understand, like the Linux kernel's RCU implementation.  ;-)
> 
> :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/