linux-kernel - Different definition in div_sc and clocksource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <10d816431003051314i3e87a2d2yab344826d14a310a@mail.gmail.com>
Date:	Sat, 6 Mar 2010 05:14:38 +0800
From:	Lin Mac <mkl0301@...il.com>
To:	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	linux-kernel@...r.kernel.org
Subject: Different definition in div_sc and clocksource_cyc2ns

hi,

While working with the clocksource, I found that the relation of cycle
and nanosecond of div_sc and clocksource_cyc2ns is different.

linux-2.6.33
div_sc in include/linux/clockchips.h suggests that clock_ticks =
(nanoseconds * factor) >> shift.
  98/*
  99 * Calculate a multiplication factor for scaled math, which is
used to convert
 100 * nanoseconds based values to clock ticks:
 101 *
 102 * clock_ticks = (nanoseconds * factor) >> shift.
 103 *
 104 * div_sc is the rearranged equation to calculate a factor from a
given clock
 105 * ticks / nanoseconds ratio:
 106 *
 107 * factor = (clock_ticks << shift) / nanoseconds
 108 */
 109static inline unsigned long div_sc(unsigned long ticks, unsigned long nsec,
 110                                   int shift)
 111{
 112        uint64_t tmp = ((uint64_t)ticks) << shift;
 113
 114        do_div(tmp, nsec);
 115        return (unsigned long) tmp;
 116}


However, clocksource_cyc2ns in include/linux/clocksource.h suggest
nanoseconds=(cycles*mult)>>shift.
 268static inline s64 clocksource_cyc2ns(cycle_t cycles, u32 mult, u32 shift)
 269{
 270        return ((u64) cycles * mult) >> shift;
 271}

But there are many others using div_sc, I don't think they got issues
with it. So what am I missing?

Best Regards,
Mac Lin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/