linux-kernel - vga_switcheroo: locking question in vga_switcheroo_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20100306110414.GB4958@bicker>
Date:	Sat, 6 Mar 2010 14:04:14 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Dave Airlie <airlied@...hat.com>
Cc:	linux-kernel@...r.kernel.org
Subject: vga_switcheroo: locking question in vga_switcheroo_debugfs_write()

Hi Dave,

drivers/gpu/vga/vga_switcheroo.c +362 vga_switcheroo_debugfs_write(101)
   277          mutex_lock(&vgasr_mutex);
   278
   279          if (!vgasr_priv.active)
   280                  return -EINVAL;

Is there a reason we return with the lock held here?  The other returns
from this function don't have the lock held.  I looked through the rest
of the file but didn't see any clues.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/