linux-kernel - Re: [RFC] drivercore: Add of_match_table to the common device drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 7 Mar 2010 10:05:34 -0800
From:	Greg KH <gregkh@...e.de>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	kay.sievers@...y.org
Subject: Re: [RFC] drivercore: Add of_match_table to the common device
	drivers

On Sat, Mar 06, 2010 at 11:47:00PM -0700, Grant Likely wrote:
> OF-style matching can be available to any device, on any type of bus.
> This patch allows any driver to provide an OF match table when CONFIG_OF
> is enabled so that drivers can be bound against devices described in
> the device tree.
> 
> Signed-off-by: Grant Likely <grant.likely@...retlab.ca>
> ---
> 
> Hi Greg and Kay,
> 
> Here is a potentially even more controversial RFC patch, the relevant
> chunk being the addition of an of-style match table to struct device_driver
> when CONFIG_OF is set.  The idea being that OF style device binding is
> applicable on any bus, regardless of the bus type.  Each bus' probe could
> be trivially extended to allow for an OF-style probe match.
> 
> I've used a #ifdef in this version, but it doesn't have to be conditional
> if that would make for cleaner code.  Either way, none of the core code
> would need to have and #ifdef bits.
> 
> As with the previous patch, I want to get feedback before I proceed too
> far down this path.

I have no objection to this patch at all, it looks good to me.

Perhaps, in the future, you might be able to move the OF driver/device
binding into the driver core itself to make it easier in the end.  But
for now, feel free to add:
	Acked-by: Greg Kroah-Hartman <gregkh@...e.de>
and send it off through your tree.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/