linux-kernel - Re: [patch] security: ima_file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ea6602021003061929y6324e019n3b7e941804638342@mail.gmail.com>
Date:	Sat, 6 Mar 2010 22:29:54 -0500
From:	Vikram Dhillon <dhillonv10@...il.com>
To:	Mimi Zohar <zohar@...ibm.com>
Cc:	Eric Paris <eparis@...hat.com>, Dan Carpenter <error27@...il.com>,
	"J.R. Okajima" <hooanon05@...oo.co.jp>,
	James Morris <jmorris@...ei.org>,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	Al Viro <viro@...iv.linux.org.uk>
Subject: Re: [patch] security: ima_file_mmap() don't just return zero

On Sat, Mar 6, 2010 at 7:47 PM, Mimi Zohar <zohar@...ibm.com> wrote:
> Vikram Dhillon <dhillonv10@...il.com> wrote on 03/06/2010 04:30:33 PM:
>
>> On Sat, Mar 6, 2010 at 6:21 AM, Dan Carpenter <error27@...il.com> wrote:
>> > It seems like we should return an error here.  That's what the comment
>> > says we should do.
>> >
>> > I also removed an out of date comment.  It wasn't needed and seemed
>> > likely
>> > to get out of date again.
>> >
>> > Signed-off-by: Dan Carpenter <error27@...il.com>
>> > ---
>
> The current code and comment are correct, as the return code will reflect
> the file's integrity appraisal, which hasn't yet been implemented.
>
> Mimi

Oh right :) I guess we aren't at a point yet to enforce integrity, so
what should the return code return? Based on the comment the code
seemed okay but I think we may have to base it on measurement
appraisal in LIM (then again, not too sure if this is the right
approach).

-- 
Regards,
Vikram Dhillon

~~~
There are lots of Linux users who don't care how the kernel works, but
only want to use it. That is a tribute to how good Linux is.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/