linux-kernel - Re: [RFC] drivercore: Add of_match_table to the common device drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100307180744.956998c5.sfr@canb.auug.org.au>
Date:	Sun, 7 Mar 2010 18:07:44 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	kay.sievers@...y.org, gregkh@...e.de
Subject: Re: [RFC] drivercore: Add of_match_table to the common device
 drivers

Hi Grant,

Just a quick note:

On Sat, 06 Mar 2010 23:47:00 -0700 Grant Likely <grant.likely@...retlab.ca> wrote:
>
> diff --git a/drivers/macintosh/macio_asic.c b/drivers/macintosh/macio_asic.c
> index 67fe13f..a5806ab 100644
> --- a/drivers/macintosh/macio_asic.c
> +++ b/drivers/macintosh/macio_asic.c
> @@ -40,8 +40,7 @@ static struct macio_chip      *macio_on_hold;
>  static int macio_bus_match(struct device *dev, struct device_driver *drv) 
>  {
>  	struct macio_dev * macio_dev = to_macio_device(dev);
> -	struct macio_driver * macio_drv = to_macio_driver(drv);
> -	const struct of_device_id * matches = macio_drv->match_table;
> +	const struct of_device_id * matches = drv->match_table;
                                                   ^^^^^^^^^^^
of_match_table

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped